Refactor the web app to fix bugs and improve maintainability #93
Open
tautomer wants to merge 4 commits intoMSDLLCpapers:mainfrom
Open
Refactor the web app to fix bugs and improve maintainability #93tautomer wants to merge 4 commits intoMSDLLCpapers:mainfrom
tautomer wants to merge 4 commits intoMSDLLCpapers:mainfrom
Conversation
Most of the in-line style has been moved to Bootstrap predefined classes or a customized CSS file in `assets/css/styles.css`.
All occurrences of inline style `style=""`, except for `dash_table.DataTable`, have been migrated to CSS classes (Bootstrap 5 built-in preferred, otherwise defined in `assets/css/styles.css`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial effort trying to overhaul the web server.
Key changes:
Fixed a bug where updating the numerical input parameter space causes errors.
The root cause is that all values obtained from html forms are strings. Treating them as numbers and passing them to
Param_Continuouswill raise an error, but existing try-except block will silently suppress the error and return a None.Added a new css file
assets/css/style.csswith all classes defined asobsd-*to avoid possible naming collision with Bootstrap.Move (almost all) occurrences of inline styles to Bootstrap (preferred) and our customized css file for better maintainability and consistency of the UI. The resulting UI is nearly identical visually to the current
mainversion, with minor changes in styling, like some font colors.Most visible difference