feat: add utility function for adding info for new entities#315
Open
LordMidas wants to merge 3 commits intodevelopmentfrom
Open
feat: add utility function for adding info for new entities#315LordMidas wants to merge 3 commits intodevelopmentfrom
LordMidas wants to merge 3 commits intodevelopmentfrom
Conversation
7c8d8e2 to
3045639
Compare
Enduriel
requested changes
Oct 20, 2023
Contributor
|
I suggest a second function that accepts an array of EntityInfo. |
Darxo
reviewed
Nov 24, 2023
Member
Author
|
Upon gaining more experience with adding new entities, I have gained more insight that leads to me to think that this PR is not enough. Namely |
Member
|
In that case let's postpone |
6677ac8 to
ae825b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.