fix: add create to skill and remove contains check from hookTree#411
Open
LordMidas wants to merge 1 commit intodevelopmentfrom
Open
fix: add create to skill and remove contains check from hookTree#411LordMidas wants to merge 1 commit intodevelopmentfrom
LordMidas wants to merge 1 commit intodevelopmentfrom
Conversation
The contains check will cause leaf classes which do not have `create` defined to not be properly hooked by our hookTree. The solution to this is to add `create` directly to the base `skill` class and then hookTree it.
Contributor
|
Will break mods that old style loop parent up until there is no create, theoretically. Practically the Spin skill from a bug does have |
LordMidas
force-pushed
the
development
branch
2 times, most recently
from
6677ac8 to
ae825b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The contains check will cause leaf classes which do not have
createdefined to not be properly hooked by our hookTree. The solution to this is to addcreatedirectly to the baseskillclass and then hookTree it.