feat: remove overwrite of vanilla skill container events#459
Open
LordMidas wants to merge 1 commit intodevelopmentfrom
Open
feat: remove overwrite of vanilla skill container events#459LordMidas wants to merge 1 commit intodevelopmentfrom
LordMidas wants to merge 1 commit intodevelopmentfrom
Conversation
- This allows other mods that want to queue before MSU and modify these events to actually work properly with their modifications. - The main goal of the overwrites, as far as I (LordMidas) understand, was to have a DRY method of applying the `wasUpdating` fix. However, upon reflection I have realized that that fix is only necessary for the `buildPropertiesForXYZ` functions. Because it is these functions which have a chance of being called from within other skill container events. The other events e.g. `onTurnEnd` etc. are very well secluded and are only ever called independently, so never run into an issue of setting `IsUpdating` to false too early. So we keep the `wasUpdating` check manually for the `buildProperties` type functions, but for the others we remove the overwrites.
LordMidas
force-pushed
the
development
branch
2 times, most recently
from
6677ac8 to
ae825b7
Compare
TaroEld
approved these changes
Dec 12, 2025
Member
TaroEld
left a comment
TaroEld
left a comment
There was a problem hiding this comment.
I don't know enough about the skills thing but the code looks OK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wasUpdatingfix. However, upon reflection I have realized that that fix is only necessary for thebuildPropertiesForXYZfunctions. Because it is these functions which have a chance of being called from within other skill container events. The other events e.g.onTurnEndetc. are very well secluded and are only ever called independently, so never run into an issue of settingIsUpdatingto false too early. So we keep thewasUpdatingcheck manually for thebuildPropertiestype functions, but for the others we remove the overwrites.Eventually with the combination of the other fix in #447 this might as well fix some hidden/unknown bugs being caused by MSU.