fix: not calling onUnequip when removing items from bag#478
Open
LordMidas wants to merge 1 commit intodevelopmentfrom
Open
fix: not calling onUnequip when removing items from bag#478LordMidas wants to merge 1 commit intodevelopmentfrom
LordMidas wants to merge 1 commit intodevelopmentfrom
Conversation
Vanilla places items which have SlotType ItemSlot.Bag in the Bag slot and during item_container.equip. Therefore, we are properly calling onEquip for such items (e.g. bandages). However, vanilla does NOT remove these items from the bag during item_container.unequip. So we are not calling onUnequip for them. This leads to unexpected behavior and runaway changes if a mod applies some changes during onEquip for such items and expects to revert said changes during onUnequip but the onUnequip never runs. We also fix the vanilla issue of item_container.unequip not handling the removal of bagged items. For this the bug report can be seen here: https://steamcommunity.com/app/365360/discussions/1/684112192552961717/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vanilla places items which have SlotType ItemSlot.Bag in the Bag slot and during item_container.equip. Therefore, we are properly calling onEquip for such items (e.g. bandages). However, vanilla does NOT remove these items from the bag during item_container.unequip. So we are not calling onUnequip for them. This leads to unexpected behavior and runaway changes if a mod applies some changes during onEquip for such items and expects to revert said changes during onUnequip but the onUnequip never runs.
We also fix the vanilla issue of item_container.unequip not handling the removal of bagged items. For this the bug report can be seen here: https://steamcommunity.com/app/365360/discussions/1/684112192552961717/