fix: validate evidence without deleted branch history#169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제
PR #168의 squash merge 후
mainCI가 evidence validator에서 실패했습니다. validator가 삭제된 feature branch의 pre-squash commit object를git ls-tree/show로 직접 읽고 있어, clean main-only checkout에서는 해당 object가 존재하지 않았습니다.수정
검증
yarn validate--single-branch mainclone + patch overlay에서yarn validategit diff --checkEvidence scope는 기존대로 internal consistency record이며 independent authenticity를 주장하지 않습니다.