fix: Fix/polyfill rethrow error#52
Open
Ma77Ball wants to merge 5 commits into
Open
Conversation
…che#4983) ### What changes were proposed in this PR? Refresh the per-module `LICENSE-binary` files so they match the bundled versions reported by the nightly drift check on `b9bbf0d`. Every entry stays in the license section it was already in, so the change is a pure version-string substitution; reviewers should still confirm each upstream's license at the new version is unchanged. Drift covered: - `frontend/LICENSE-binary` — `lodash` 4.17.23 → 4.18.1 - `amber/LICENSE-binary-java` and the 5 platform services (`access-control-service`, `config-service`, `file-service`, `workflow-compiling-service`, `computing-unit-managing-service`) — `org.checkerframework.checker-qual` 3.42.0 → 3.52.0 - `amber/LICENSE-binary-python` — - `hf-xet` 1.4.3 → 1.5.0 - `markdown-it-py` 4.0.0 → 4.1.0 - `pydantic` 2.13.3 → 2.13.4 - `pydantic-core` 2.46.3 → 2.46.4 All bumps are transitive, which is why PR-mode runs (`check_binary_deps.py --ignore-transitive-version`) accepted them; only the nightly strict run flagged the drift. ### Any related issues, documentation, discussions? Resolves apache#4974. ### How was this PR tested? - `python3 bin/licensing/test_check_binary_deps.py` — 27 tests pass. - The check that originally flagged the drift (the nightly `License Binary Checker` workflow, which calls `build.yml` with `mode: nightly` and runs `check_binary_deps.py` without `--ignore-transitive-version`) is exercised by the build matrix on this PR; the previously-failing license steps for frontend, amber, the five platform services, and python are expected to turn green. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.7, 1M context) Co-authored-by: Bot Bai <bobbairobot@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…4990) ### What changes were proposed in this PR? Delete the two `rest-uri` lines from `common/config/src/main/resources/storage.conf`: ``` rest-uri = "" rest-uri = ${?STORAGE_ICEBERG_CATALOG_REST_URI} ``` This hyphenated flat key (`storage.iceberg.catalog.rest-uri`) is not read by any Scala code. The active key is the nested `storage.iceberg.catalog.rest.uri` (a few lines below in the `rest { … }` block), which already consumes the same `STORAGE_ICEBERG_CATALOG_REST_URI` env var. | Key | Read by Scala? | | --- | --- | | `storage.iceberg.catalog.rest-uri` (deleted) | No | | `storage.iceberg.catalog.rest.uri` (kept) | `StorageConfig.icebergRESTCatalogUri` | ### Any related issues, documentation, discussions? Closes apache#4989 ### How was this PR tested? ``` sbt "Config/compile" [success] Total time: 3 s ``` Pure config-cleanup; no Scala / Python / shell consumer of the deleted key. The `STORAGE_ICEBERG_CATALOG_REST_URI` env var continues to flow into amber/CU through the nested `rest.uri` key. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.7) Co-authored-by: Jiadong Bai <43344272+bobbai00@users.noreply.github.com>
…e#4986) ### What changes were proposed in this PR? - Renamed .github/workflows/take-commands.yml → .github/workflows/comment-commands.yml, since the workflow now handles more than just /take and /untake. - Added a new request-review job that handles two new slash commands on PRs: - /request-review @alice @bob requests reviews from the listed users/teams. - /unrequest-review @alice cancels a pending review request. - Authorization: PR author (fast path) or any committer with write/maintain/admin permission. Anyone else is rejected and logged. - Supports both individual users (@alice) and teams (@org/team-name); routes them to the correct API bucket. - Strips self-mentions before calling the API so the atomic call doesn't fail over a single bad name. - Workflow renamed Issue take commands → Comment commands and granted pull-requests: write. - Avoids the /review namespace so it stays free for future use (e.g., self-review). ### Any related issues, documentation, or discussions? Closes: apache#4975 ### How was this PR tested? Tested on my local fork. ### Was this PR authored or co-authored using generative AI tooling? Co-Authored with Claude Opus 4.7 in Compliance with ASF
### What changes were proposed in this PR?
Bump all Scala/Java microservices from Java 11 to Java 17 LTS, and
centralize the JDK 17 `--add-opens` flags through `.jvmopts` as a
single source of truth.
**Toolchain bumps**
- 8 Dockerfiles under `bin/`: build base
`sbtscala/scala-sbt:eclipse-temurin-jammy-11.0.17_8_1.9.3_2.13.11`
→ `...-17.0.5_8_1.9.3_2.13.11` (same sbt 1.9.3 + Scala 2.13.11);
runtime `eclipse-temurin:11-{jdk,jre}-jammy` → `17-{jdk,jre}-jammy`.
- `.github/workflows/build.yml` and `build-and-push-images.yml`:
`java-version: 11` → `17` (matrix entries + 5 `setup-java` steps).
- `AGENTS.md`: toolchain table.
**`.jvmopts` as single source of truth**
`.jvmopts` lists the seven `--add-opens` flags JDK 17 needs for the
runtime (Pekko, Apache Arrow, Ehcache `SizeOf`, Pekko Kryo
serialization). The same file reaches every JVM the build launches:
- sbt's own JVM: sbt's launcher reads `.jvmopts` directly.
- forked test JVMs (sbt-jacoco): `ThisBuild / Test / javaOptions ++=
JdkOptions.jvmFlags(...)` in `build.sbt`.
- sbt-native-packager `bin/<svc>` launchers in production dists:
`Universal / javaOptions ++= JdkOptions.jvmFlags(...).map("-J" + _)`,
bundled per-project via `asfLicensingSettings` (Universal does not
cascade from ThisBuild).
- IntelliJ run configs `.run/ComputingUnit{Master,Worker}.run.xml`:
`VM_PARAMETERS=@$PROJECT_DIR$/.jvmopts` (JDK 9+ argfile expansion).
`project/JdkOptions.scala` (modeled on Pekko's) reads the file once
and exposes a `Seq[String]` for the build to wire up.
### Any related issues, documentation, discussions?
Closes apache#4937. Refs discussion #4001.
### How was this PR tested?
CI's amber job now finishes in
single-digit minutes, with all 5 `jacoco` tasks passing. Local
verification: `sbt show ThisBuild / Test / javaOptions` and
`sbt show <project> / Universal / javaOptions` confirm flag
propagation across all subprojects; `java @.jvmopts -version`
confirms the JDK accepts the argfile cleanly; running amber
`jacoco` locally hits zero `InaccessibleObjectException`.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)
---------
Co-authored-by: Xinyuan Lin <xinyual3@uci.edu>
Co-authored-by: Bot Bai <bobbairobot@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…itest workers survive Zone-leaked errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Any related issues, documentation, discussions?
How was this PR tested?
Was this PR authored or co-authored using generative AI tooling?