adding additional adjustments to the elements of relatedItems for datacite-article-xslt#165
Merged
physikerwelt merged 4 commits intomainfrom Feb 7, 2025
Merged
adding additional adjustments to the elements of relatedItems for datacite-article-xslt#165physikerwelt merged 4 commits intomainfrom
physikerwelt merged 4 commits intomainfrom
Conversation
Contributor
Author
|
i will update the crosswalks for datacite after this PR . |
physikerwelt
requested changes
Feb 7, 2025
Member
physikerwelt
left a comment
physikerwelt
left a comment
There was a problem hiding this comment.
Can you apply automatic indention to the file to make it better readable?
| <xsl:value-of select="series/issue"/> | ||
| </issue> | ||
| <!-- Process pages start with first page and end with last page --> | ||
| </xsl:if> |
Member
There was a problem hiding this comment.
Is this indented correctly?
Contributor
Author
There was a problem hiding this comment.
it works actually accodringly however i made the automatic indention and i will also fix the differences that are occuring the the unittest
physikerwelt
requested changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaRDI Pull Request
Changes:
especially the mandatory properties like following
such if title , creator , pub year , publisher wont have values in our metadata
they will take the value :unav which means unavailable
and the other properties if they dont have values then they should not appear in the result .
-no further work needed for unittest or reference.xml ( the update dont effect the current files but it is considered for the varitery of our metadata )