Merged
Conversation
added 9 commits
February 18, 2025 01:50
Contributor
Author
|
i know that i made a lot of commits , but i had to update many files and i fixed 3 failing unit tests because the update of the api version , at least it works at the end :D |
Collaborator
|
This is a great contribution, but please, as much as possible, split your work into smaller PR whenever it is feasible to ease my reviewing work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaRDI Pull Request
Changes:
adding a lot of conditions to most of properties ( after noticing in the oai records that are many properties in different files have missing fields or zbmath conent copy right) so to avoid these results i added instead the new datacite property :unav or :unkn
such it could be better in the results
also noticed in the relateditems ( references ) many records have missing doi values and instead zbmath content etc...
so i added new conditions that guarantees to have url's instead of doi
the PR is big but i wanted to get it done all by once .
a small change in the reference only positional ( which means the main result is not being effected) but i took care of all possiblities that could happen)