Conversation
Contributor
Author
|
i fixed one unittest and i am currently fixing the other unittest it will be fixed soon and you could review the PR to be merged |
Contributor
Author
|
again it was not supposed to be a big PR but it is like that because the metadata of plain.xml for software have been changed from the source ( rest-api) therefore many changes needed to be done . my main work is in the first commit for codemeta |
Collaborator
|
I agree that the plain XML content update and test fixing result in numerous lines, which do not impede the readability of the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaRDI Pull Request
Changes:
adjust the XSLT templates of id ( Identifier) and url in software for codemeta
the templates will work like following logic to avoid the prefix " oai:swmath.org: " and give us only the value
of the id and url in the oai records
i could do the same update for datacite records if needed.