Skip to content

add an inner function to extract tags#185

Merged
Mazztok45 merged 4 commits intomainfrom
add_software
May 5, 2025
Merged

add an inner function to extract tags#185
Mazztok45 merged 4 commits intomainfrom
add_software

Conversation

@Shirazos7
Copy link
Contributor

MaRDI Pull Request

Changes:

  • the inner function should collaborate with the outer function extract tags in getAsXml.py

  • it should add the softwares to the openaire set as we already agreed.

@Mazztok45
Copy link
Collaborator

I like the function, but it should not be written into another function itself; it can be confusing. Please write add_software(): out of extract_tags(result):

@Shirazos7
Copy link
Contributor Author

okay i will adjust the work

@Shirazos7
Copy link
Contributor Author

@Mazztok45 i moved the function outside and now it is written separately and only called inside the extract tags function , made another small commit just to correct the blank and whitespaces for deep source warnings sake

@Mazztok45 Mazztok45 merged commit 2b55cac into main May 5, 2025
2 checks passed
@Shirazos7 Shirazos7 deleted the add_software branch May 5, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants