Conversation
Collaborator
|
I like the function, but it should not be written into another function itself; it can be confusing. Please write |
Contributor
Author
|
okay i will adjust the work |
Contributor
Author
|
@Mazztok45 i moved the function outside and now it is written separately and only called inside the extract tags function , made another small commit just to correct the blank and whitespaces for deep source warnings sake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaRDI Pull Request
Changes:
the inner function should collaborate with the outer function extract tags in getAsXml.py
it should add the softwares to the openaire set as we already agreed.