Fixed AfterPrice not working on configurables#42
Open
kolaente wants to merge 2 commits intoMagenerds:masterfrom
Open
Fixed AfterPrice not working on configurables#42kolaente wants to merge 2 commits intoMagenerds:masterfrom
kolaente wants to merge 2 commits intoMagenerds:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a product does not have a base price but one of its child have, the html tag to show the base price was not created if the parent product didn't have a product amount configured. This resulted in the base price not showing at all for children because the js didn't have a container to add the base price into.
This pr adds an extra check to see if the product has at least one child which has a base price amount configured. If that's the case, it renders the html tag (which will be empty if no child is selected)