Skip to content

fix: do not retry on wrong password (28P01) with sslmode=allow/prefer #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mauricio0129 wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −2
Open

fix: do not retry on wrong password (28P01) with sslmode=allow/prefer #1331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions asyncpg/connect_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1103,9 +1103,14 @@ async def __connect_addr(
except (
exceptions.InvalidAuthorizationSpecificationError,
exceptions.ConnectionDoesNotExistError, # seen on Windows
):
) as exc:
tr.close()


# Do not retry on wrong password (28P01) — the issue is credentials,
# not SSL negotiation. Only pg_hba.conf rejections (28000) warrant a retry.
if isinstance(exc, exceptions.InvalidPasswordError):
raise

# retry=True here is a redundant check because we don't want to
# accidentally raise the internal _RetryConnectSignal to the user
if retry and (
Expand Down