Conversation
Apricot-S
requested changes
Feb 5, 2026
Apricot-S
requested changes
Feb 5, 2026
.github/wiki/v2-English.md
Outdated
| tiles, | ||
| win_tile, | ||
| melds=melds, | ||
| dora_indicators=TilesConverter.string_to_136_array(honors='44447777'), |
Collaborator
There was a problem hiding this comment.
Instead of 8 dora, please make it 4 dora and 4 ura dora.
To match the number of kans, it may be better to use 5 doras each. However, this is just an example, so I'm not sure if it's necessary to go that far.
In the current example, there are also eight of the same tile (7z).
What do you think?
Contributor
Author
There was a problem hiding this comment.
I think just adding ura dora is fine for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119
Also I deployed this branch to test all changes before merging to master: https://github.com/MahjongRepository/mahjong/wiki
It was required to make sure that wiki changes properly updated, since changes were huge. For minor wiki updates we don't need that, we can deploy them from master after PR.