refactor: optimize performance for hand calculations#189
Merged
Conversation
Apricot-S
requested changes
Feb 6, 2026
Apricot-S
requested changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it is the latest round of optimizations. All low-hanging fruit have been picked (only removal of
is_agariremained, but it would be done in separate PR).We can optimize it further for sure, but it would require more invasive changes to the architecture, and the goal of this lib is not to be the fastest mahjong lib out there, but rather a good balance of speed, correctness, and maintainability. For super fast libs there are Rust/C versions available.
For example, we can get a lot of performance gains by getting rid of
Yaku.is_condition_met()and just pre-calculate all honors, suits and etc per hand and use these ints to calculate all yaku, but it is not the change that I want to do in this lib.Summary of optimization patterns used:
And all 2.1kk validation hands passed successfully.
Benchmark Results
Benchmark was run with n=5, limit=200000.
Old
New
Overall profile
estimate_hand_valuefunction