Open
Conversation
|
Is it possible to merge this @Fetz? I am currently relying on this fork to use this library but would prefer to use the official repo. Cheers. |
iq-dot
added a commit
to iq-dot/VPAIDHTML5Client
that referenced
this pull request
Jul 28, 2017
* Add global radio ad tag Add production, test and debug build commands * Add nigella site adtags
JanSunavec
approved these changes
Oct 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a problem while using your
videojs-vast-vpaidplugin. When the player and libraries are used inside a friendly iframe, the postMessage sends a "null" as the origin.To solve that, we I'm using
window.parent.locationinstead ofwindow.location.It's safe for non-iframed players as well because if a window does not have a parent, its parent property is a reference to itself.
Here's an example showing both the issue and the solution:
http://jsbin.com/boricow/edit?js,output
Having the player inside of a friendly iframe allows it to work along virtual-dom based apps.