feat: Media Player Visualizer (cava integration)#542
Open
ashlcx wants to merge 8 commits into
Open
Conversation
MalpenZibo
reviewed
Mar 30, 2026
Comment on lines
+473
to
+477
| Gradient { | ||
| low: HexColor, | ||
| mid: Option<HexColor>, | ||
| high: HexColor, | ||
| }, |
Owner
There was a problem hiding this comment.
What if we declare this like optional values? I mean, the user could simply specify gradient and use the base palette (Success -> warn (right now we use a weak danger for this, but after the iced update, there will be a dedicated value) -> danger) and only if necessary override the specific color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature addition of a cava visualizer to media player. Only shows media is playing through the active player.
Includes configuration options for the following:
show_visualizerfalsevisualizer_bar_count8visualizer_framerate60visualizer_padding3visualizer_color"Text"visualizer_channels"Stereo""Stereo"or"Mono".visualizer_mono_option"Average""Average","Left", or"Right".Example Config: