feat(tray): left/right click behavior#729
feat(tray): left/right click behavior#729alexandre-abrioux wants to merge 1 commit intoMalpenZibo:mainfrom
Conversation
|
I'm not sure about this change. The default config behavior should remain the old one. Left-clicking the icon opens the menu. The problem with opening the app is more about the scope of the module. This is a tray module and not a Docker bar. I do not expect to be able to open an application from there directly, maybe only from some tray menu option if present. Anyway, it's a minimal change, so we could also include it. Not sure about the configuration, in this way it's possible to set both clicks on the same action, which doesn't make much sense. We could place a simple bool to invert the action.
|
|
@MalpenZibo Thanks for the review 🙏 To keep the exact behavior we have today, what do you think about extending the enum with a third values: [tray]
left_click = "menu"
right_click = "none"Users could configure the following if they want: [tray]
left_click = "open"
right_click = "menu" |
Closes #492
Change description
This PR adds support for configuring the left- and right-click behavior for tray items. We can now either:
To consider
I felt it was an OK change to make because:
However, I understand this is mostly subjective and likely a matter of personal preference. I'm happy to revert that part. Please let me know if you consider this unwanted and would like to revert the default left-click behavior to its previous state.