Fix double-subscription crash when Settings module is enabled#732
Open
romanstingler wants to merge 1 commit intoMalpenZibo:mainfrom
Open
Fix double-subscription crash when Settings module is enabled#732romanstingler wants to merge 1 commit intoMalpenZibo:mainfrom
romanstingler wants to merge 1 commit intoMalpenZibo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in
src/app.rsin thesubscription()method.When Settings was in the module list, the code would subscribe to Settings' underlying D-Bus services (UPower, PulseAudio, NetworkManager) twice:
once through
self.modules_subscriptions(), and again explicitly at the end ofSubscription::batch()for OSD support.This double-subscription could corrupt D-Bus proxy state and cause segmentation faults. The fix checks if Settings is in any module list and only adds the explicit subscription when it's not present, eliminating the duplicate while maintaining OSD functionality.
Related to #727.