Use send for choice operations

[kbrock]

Pulled out of #189

This looks up the operation name up front and avoids the case

[agrare]

Nice, this wasn't my favorite code to write :D thanks for cleaning it up

[Fryguy]

This method name scares me a little because it shadows a common Ruby method for object equality.

[kbrock]

@Fryguy Still thinking about this comment

We define @next and @end because that is the name of the parameter.

Here, we define equals? because it is derived from the operation Equals.

Do we want to add an string to the beginning of the phrase to have methods like opEquals? ?

[Fryguy]

+1 for a op prefix - op_equals? would work for me too.

next and end are also good examples of interface names that scare me because they collide with Ruby keywords. The difference there is that the keywords are bare, so they only affect scoped usage. For example, an external user of Map would do map.next or map.end, which has a defined receiver, so it doesn't collide, but a locally scoped method might call next bare, and then you have an ambigous receiver vs keyword.

Note that next also can collide with ruby debug's next command - no idea what would happen there.

[Fryguy]

Actually i just played around with locally, and you can't even call next without a receiver

# next_end.rb
class Foo
  def next
    puts "next"
  end

  def end
    puts "end"
  end
end

without a receiver:

class Foo
  def call_next_no_receiver
    next
  end
end

(irb):2:in `require_relative': --> /Users/jfrey/dev/test/next_end.rb
Invalid next
   1  class Foo
  10    def call_next_no_receiver
> 11      next
  12    end
  13  end

/Users/jfrey/dev/test/next_end.rb:11: Invalid next (SyntaxError)
	from (irb):2:in `<main>'
	from <internal:kernel>:187:in `loop'
	from /Users/jfrey/.rubies/ruby-3.3.6/lib/ruby/gems/3.3.0/gems/irb-1.13.1/exe/irb:9:in `<top (required)>'
	from /Users/jfrey/.gem/ruby/3.3.6/bin/irb:25:in `load'
	from /Users/jfrey/.gem/ruby/3.3.6/bin/irb:25:in `<main>'

making it syntactically correct by using next in a loop

class Foo
  def call_next_no_receiver
    5.times do
      next
      puts "skipped"
    end
  end

  def call_next_w_receiver
    5.times do
      self.next
      puts "not skipped"
    end
  end
end

see that you must use a receiver or the keyword takes precedence

irb(main):001> require_relative './next_end'
=> true
irb(main):002> Foo.new.call_next_no_receiver
=> 5
irb(main):003> Foo.new.call_next_w_receiver
next
not skipped
next
not skipped
next
not skipped
next
not skipped
next
not skipped
=> 5