Draft
Conversation
This test uses coordinate_check_method which hasn't been released yet
) PRT docs and error messages previously failed to distinguish between cells excluded from the model grid with IDOMAIN and cells merely inactive due e.g. to drying. These two concepts are distinct and should not be confused: PRT will not permit a particle to be released into a cell with IDOMAIN = 0 (excluded from the simulation) or -1 (vertical pass through), but it will permit release into an inactive cell. Behavior in this case is determined by factors such as whether the DRAPE option is activated, whether the flow model uses the Newton formulation, and (if so) which DRY_TRACKING_METHOD is configured.
…te derivative at C=0
Co-authored-by: Christian Langevin <clange001@icloud.com> Co-authored-by: Eric Morway <emorway@usgs.gov>
* fix(sfe): fix sfe storage issue * fix spelling * fix an assertion...not sure how it was passing before. Manual inspection confirms test is acting as it should
…change (MODFLOW-ORG#2621) * - disable synchronization of mover data when not a primary exchange made bookkeeping on synchronizing exchange items (hopefully) more transparent -improved documentation * - remove unused * - add note * - add release note * - finished merging notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the revised sorption formulation which ensures mass balance.
An autotest is added that verifies that it does
Checklist of items for pull request
ruffon new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.fprettifyFor additional information see instructions for contributing and instructions for developing.