fix(text): apply constructor color to Text/MarkupText mobject#4846
Closed
Chessing234 wants to merge 1 commit into
Closed
fix(text): apply constructor color to Text/MarkupText mobject#4846Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
The color passed to Text/MarkupText is baked into the glyph SVGs but the parent mobject keeps its default fill, so get_color() returned the wrong value. Set the parent fill/stroke (family=False) to preserve per-character colors. Fixes ManimCommunity#4817.
Author
|
Closing as duplicate of #4844, which already fixes this and adds a regression test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Text("test", color=WHITE).get_color()returns#000000, not#FFFFFF(#4817). The color is baked into the glyph SVGs during rendering, but the parent mobject keeps its default fill, soget_color()(which reads the parent fill) ignores the constructor argument.set_color()after construction works, which is the inconsistency users hit.Fix
After init, set the parent mobject's fill/stroke to the parsed color with
family=False, so per-charactert2c/gradient colors on the glyphs are preserved whileget_color()reports the right value. Applied to bothTextandMarkupText.Closes #4817.