fix(creation): honor suspend_mobject_updating in Create/Uncreate#4849
Closed
Chessing234 wants to merge 1 commit into
Closed
fix(creation): honor suspend_mobject_updating in Create/Uncreate#4849Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
ShowPartial rebuilds the mobject each frame from starting_mobject via pointwise_become_partial. begin() only suspended self.mobject, so the reference copy's updaters kept running and their drift leaked back into the result, making suspend_mobject_updating a no-op. Suspend the starting_mobject too when the flag is set. Fixes ManimCommunity#4763 Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Superseded by rebased #4879 (old branch had diverged from main). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog / Overview
Create/Uncreateignoredsuspend_mobject_updating: updaters on the target kept running during the animation.Cause
ShowPartialrebuilds the mobject every frame fromstarting_mobjectviapointwise_become_partial.Animation.begin()only suspendsself.mobject, so the reference copy's updaters kept firing (it is inget_all_mobjects_to_update) and their drift was copied back into the result each frame — making the flag a no-op.Fix
When
suspend_mobject_updatingis set, also suspendstarting_mobjectinShowPartial.begin().Testing
Existing
tests/module/animation/test_creation.pypass.Fixes #4763
Made with Cursor