Skip to content

fix(geometry): preserve Angle.angle_value across become() #4853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Chessing234 wants to merge 1 commit into from
+8 −0
Closed

fix(geometry): preserve Angle.angle_value across become() #4853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions manim/mobject/geometry/line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1124,6 +1124,14 @@ def construct(self):
"""
return self.angle_value / DEGREES if degrees else self.angle_value

def become(self, mobject: Mobject, *args: Any, **kwargs: Any) -> Self:
# become() only copies points/submobjects, not angle_value, so
# always_redraw(lambda: Angle(...)) left get_value() stale (#4512).
super().become(mobject, *args, **kwargs)
if isinstance(mobject, Angle):
self.angle_value = mobject.angle_value
return self

@staticmethod
def from_three_points(
A: Point3DLike, B: Point3DLike, C: Point3DLike, **kwargs: Any
Expand Down
Loading