docs(space_ops): correct cartesian_to_spherical return order#4856
Open
Chessing234 wants to merge 1 commit into
Open
docs(space_ops): correct cartesian_to_spherical return order#4856Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
The docstring claimed the function returns (distance, phi, theta), but it returns [r, theta, phi] (matching spherical_to_cartesian). Fix the description and document each returned value. Fixes ManimCommunity#3123 Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
Refrain from mass-opening too many AI-generated PRs. This is the 15th PR you generate in a span of 2 days. |
Author
|
ok |
Author
|
Understood, and apologies for the volume — that's fair feedback. I'll stop opening new PRs here and slow down considerably. Happy to close some of the open ones so they're easier to review a few at a time; just let me know which (if any) are worth keeping and I'll prioritize those and drop the rest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cartesian_to_sphericaldocumented its return value as(distance, phi, theta), but it actually returns[r, theta, phi](consistent withspherical_to_cartesian, so the two round-trip).Returnssection describing each value.Fixes #3123
Test plan
pytest tests/module/utils/test_space_ops.py::test_polar_coords(confirms the actual(r, theta, phi)return order).Made with Cursor