fix(svg): propagate constructor z_index to glyph submobjects#4857
Closed
Chessing234 wants to merge 2 commits into
Closed
fix(svg): propagate constructor z_index to glyph submobjects#4857Chessing234 wants to merge 2 commits into
Chessing234 wants to merge 2 commits into
Conversation
Glyphs are added after super().__init__ stored self.z_index, so a z_index passed to Text/MathTex/SVGMobject never reached the glyphs and was ignored when rendering z-order. Propagate it to the whole family. Fixes ManimCommunity#4667 Co-authored-by: Cursor <cursoragent@cursor.com>
Assign z_index on the family directly and guard with getattr so the OpenGL renderer (which lacks set_z_index / a z_index attribute) no longer crashes. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Text(..., z_index=3)(and other SVG-based mobjects likeMathTex) ignored thez_indexbecause glyph submobjects are created aftersuper().__init__storedself.z_index. The glyphs keptz_index=0, so z-ordering was wrong during rendering.z_indexto the whole family once the glyphs exist.Before:
Fixes #4667
Test plan
pytest tests/module/mobject/text/test_text_mobject.py::test_z_index_propagates_to_glyphspytest tests/module/mobject/svg tests/module/mobject/text(pre-existingtypst-dependency failures unrelated to this change)Made with Cursor