fix(geometry): clamp round_corners cut_off on collinear vertices#4873
Closed
Chessing234 wants to merge 1 commit into
Closed
fix(geometry): clamp round_corners cut_off on collinear vertices#4873Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Prevents tan(angle/2) blow-up when consecutive polygon vertices are collinear, which could allocate unbounded memory during curve insertion. Fixes ManimCommunity#3052 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cut_off_lengthinPolygram.round_cornersto half the shorter adjacent edgeMemoryErrorwhen collinear vertices maketan(angle/2)divergeFixes #3052
Test plan
pytest tests/module/mobject/geometry/test_unit_geometry.py::test_round_corners_collinear_points_stays_finiteMade with Cursor