fix(tex): match substrings_to_isolate across newlines#4874
Closed
Chessing234 wants to merge 1 commit into
Closed
Conversation
Use re.DOTALL in _locate_first_match so substrings on later lines of multi-line Tex/MathTex strings are isolated again. Fixes ManimCommunity#4617 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
re.DOTALLto_locate_first_matchso.spans newlinessubstrings_to_isolate/get_part_by_texfor multi-line stringsFixes #4617
Test plan
pytest tests/module/mobject/text/test_texmobject.py::test_locate_first_match_multiline_substringMade with Cursor