fix(scene): warn when overlapping .animate targets share play()#4875
Closed
Chessing234 wants to merge 5 commits into
Closed
fix(scene): warn when overlapping .animate targets share play()#4875Chessing234 wants to merge 5 commits into
Chessing234 wants to merge 5 commits into
Conversation
Detect multiple _MethodAnimation instances in one play() that touch the same mobject family and log a warning about argument-order overrides. Fixes ManimCommunity#4865 Co-authored-by: Cursor <cursoragent@cursor.com>
for more information, see https://pre-commit.ci
manim.logger has propagate=False; target it explicitly in caplog. Co-authored-by: Cursor <cursoragent@cursor.com>
for more information, see https://pre-commit.ci
caplog does not capture manim.logger (propagate=False + RichHandler). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scene.compile_animationswhen multiple.animatebuilds in oneplay()share a mobject familyFixes #4865
Test plan
pytest tests/module/scene/test_scene.py::test_warn_overlapping_animate_targetsMade with Cursor