fix(scene): record audio after cached animation replays#4876
Closed
Chessing234 wants to merge 1 commit into
Closed
fix(scene): record audio after cached animation replays#4876Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Reset skip_animations when a play() only skipped frame rendering due to cache hits, so add_sound() is not dropped between cached waits. Fixes ManimCommunity#4751 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skip_animationsafter cache-only play() skips (Cairo + OpenGL)add_sound()was silently dropped when called after cachedwait()segmentsFixes #4751
Test plan
pytest tests/module/scene/test_sound.py::test_add_sound_after_cached_waitMade with Cursor