fix(tex): keep MathTex bounding box stable after shift#4877
Closed
Chessing234 wants to merge 2 commits into
Closed
fix(tex): keep MathTex bounding box stable after shift#4877Chessing234 wants to merge 2 commits into
Chessing234 wants to merge 2 commits into
Conversation
Empty MathTexPart submobjects inflated the bbox on move; use VectorizedPoint placeholders like the pre-0.20 workaround. Fixes ManimCommunity#4643 Co-authored-by: Cursor <cursoragent@cursor.com>
for more information, see https://pre-commit.ci
Author
|
Closing — fix breaks test_multi_part_tex_with_empty_parts and bbox shift no longer reproduces on current main. Will revisit with a narrower approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VectorizedPointplaceholders for emptyMathTexPartsubmobjects.shift()Fixes #4643
Test plan
pytest tests/module/mobject/text/test_texmobject.py::test_mathtex_bounding_box_stable_after_shiftMade with Cursor