Migrate logger to 2.x#2
Merged
O-Hannonen merged 1 commit intoMankeli-Software:mainfrom May 21, 2025
Merged
Conversation
6 tasks
Contributor
|
Thank you for your contribution and sorry for the delay in responding! |
6 tasks
Contributor
Author
|
@O-Hannonen thank you for taking the time to review the PR! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1
loggerto 2.xIdeally,
LoggerCallback's signature should be changed to match the new signature oflogger's callback, but that would introduce a breaking change. I make an adapter function that converts the new callback's signature to the old one (which is used byLoggerCallback). The makes my changes non-breakingIf you decide that changing the
LoggerCallback's signature (and thus introducing a breaking change) is preferred, let me know - I will update my PR.In addition,
verbosewas renamed totrace; andwtfwas renamed tofatal. I kept the original function names.Conventional Type