Skip to content

feat: migrate to opala (MAPCO-7171)#30

Merged
shimoncohen merged 10 commits into
masterfrom
switch-to-opala
Sep 18, 2025
Merged

feat: migrate to opala (MAPCO-7171)#30
shimoncohen merged 10 commits into
masterfrom
switch-to-opala

Conversation

@shimoncohen

Copy link
Copy Markdown
Contributor
Question Answer
Bug fix
New feature
Breaking change
Deprecations
Documentation
Tests added
Chore

@shimoncohen shimoncohen self-assigned this Sep 3, 2025
@shimoncohen shimoncohen added the dependencies Pull requests that update a dependency file label Sep 3, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates from a custom Envoy/OPA authorization setup to a simplified nginx-based solution called "opala". The changes significantly reduce complexity by removing Envoy proxy and OPA containers while maintaining authorization capabilities through nginx JavaScript modules.

  • Removes Envoy proxy, OPA containers, and related configuration files
  • Migrates to nginx-based authorization using JavaScript modules and external OPA service calls
  • Updates nginx configuration to support OpenTelemetry tracing and external authorization validation

Reviewed Changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
helm/values.yaml Removes authentication/OPA config, updates nginx settings with authorization URL and OpenTelemetry configuration
helm/templates/route.yaml Removes OpenShift route template entirely
helm/templates/opa-secret.yaml Removes OPA policy secret template
helm/templates/nginx-service.yaml Removes nginx service template
helm/templates/nginx-deployment.yaml Removes complex nginx deployment with Envoy/OPA sidecars
helm/templates/nginx-configmap.yaml Simplifies configmap by removing JWT JavaScript and making nginx.conf templated
helm/templates/ingress.yaml Removes ingress template
helm/templates/ingress-tls-secret.yaml Removes TLS secret template
helm/templates/envoy-configmap.yaml Removes Envoy configuration template
helm/templates/_helpers.tpl Adds OpenTelemetry trace configuration helper function
helm/config/policy.rego Removes OPA policy file
helm/config/nginx.conf Updates to load OpenTelemetry module and support authorization JavaScript
helm/config/log_format.conf Updates OpenTelemetry variable names from opentelemetry_ to otel_ prefix
helm/config/jwt.js Removes JWT parsing JavaScript module
helm/config/envoy.yaml Removes Envoy proxy configuration
helm/config/default.conf Adds OpenTelemetry tracing and external OPA authorization validation
helm/Chart.yaml Adds dependency on common nginx chart
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread helm/config/nginx.conf
Comment thread helm/config/default.conf
@shimoncohen shimoncohen changed the title feat: migrate to opala feat: migrate to opala ( MAPCO-7171) Sep 9, 2025
@shimoncohen shimoncohen changed the title feat: migrate to opala ( MAPCO-7171) feat: migrate to opala (MAPCO-7171) Sep 9, 2025

@syncush syncush left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be easy to add mc-labels-annotation for this chart, please do so.
it is a quick win

Comment thread helm/values.yaml Outdated
Comment thread helm/config/nginx.conf Outdated
Comment thread helm/config/default.conf
Comment thread helm/values.yaml
alebinson
alebinson previously approved these changes Sep 11, 2025

@alebinson alebinson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically looks good to me.
10x!
Think in this case, let's run with the change. Errors, is any, we'll fix

syncush
syncush previously approved these changes Sep 11, 2025
Co-authored-by: Netanel Cohen <34451523+netanelC@users.noreply.github.com>
netanelC
netanelC previously approved these changes Sep 17, 2025
@shimoncohen shimoncohen merged commit eb98973 into master Sep 18, 2025
8 checks passed
@syncush syncush deleted the switch-to-opala branch September 18, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants