Skip to content

chore: add Helm infra labels and annotations (MAPCO-9060)#76

Merged
roicohen326 merged 12 commits into
masterfrom
helm/infra-labels-and-annotations
Dec 7, 2025
Merged

chore: add Helm infra labels and annotations (MAPCO-9060)#76
roicohen326 merged 12 commits into
masterfrom
helm/infra-labels-and-annotations

Conversation

@roicohen326

@roicohen326 roicohen326 commented Dec 2, 2025

Copy link
Copy Markdown
Question Answer
Bug fix
New feature
Breaking change
Deprecations
Documentation
Tests added
Chore

add "mclabels" labels and annotation support

image

@roicohen326 roicohen326 changed the title Helm/infra labels and annotations Helm/infra labels and annotations (MAPCO-9060) Dec 2, 2025
@roicohen326 roicohen326 changed the title Helm/infra labels and annotations (MAPCO-9060) Helm/infra labels and annotations (MAPCO-8004) Dec 2, 2025
@roicohen326 roicohen326 changed the title Helm/infra labels and annotations (MAPCO-8004) Helm/infra labels and annotations (MAPCO-9060) Dec 2, 2025
@razbroc

razbroc commented Dec 3, 2025

Copy link
Copy Markdown

title should have ":" instead of "/"

@CL-SHLOMIKONCHA CL-SHLOMIKONCHA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add call for selectorLabels within "service.yaml" file at the bottom of the selector scope

Comment thread .DS_Store Outdated
Comment thread helm/templates/mapproxy-bundle.yaml Outdated
Comment thread helm/templates/mapproxy-bundle.yaml Outdated
Comment thread helm/templates/mapproxy-bundle.yaml Outdated
Comment thread helm/values.yaml Outdated
Comment thread helm/templates/_helpers.tpl Outdated
Comment thread helm/templates/_helpers.tpl Outdated
@roicohen326 roicohen326 changed the title Helm/infra labels and annotations (MAPCO-9060) Helm:infra labels and annotations (MAPCO-9060) Dec 3, 2025

@razbroc razbroc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on first team PR!

Comment thread helm/Chart.yaml
Comment thread helm/values.yaml
Comment thread .DS_Store Outdated
Comment thread helm/values.yaml
Comment thread helm/templates/mapproxy-bundle.yaml
Comment thread helm/templates/mapproxy/mapproxy-container.yaml
Comment thread helm/templates/mapproxinator/mapproxinator-container.yaml
Comment thread helm/values.yaml
Comment thread helm/templates/mapproxy/mapproxy-container.yaml
Comment thread helm/templates/mapproxy/service.yaml
Comment thread helm/templates/_helpers.tpl
Comment thread helm/templates/mapproxy-bundle.yaml Outdated
@razbroc razbroc changed the title Helm:infra labels and annotations (MAPCO-9060) Helm: infra labels and annotations (MAPCO-9060) Dec 4, 2025
Comment thread helm/templates/_helpers.tpl Outdated
Comment thread helm/templates/mapproxy-bundle.yaml Outdated
Comment thread helm/templates/mapproxy-bundle.yaml Outdated
Comment thread helm/templates/mapproxy-bundle.yaml Outdated

@razbroc razbroc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@roicohen326 roicohen326 changed the title Helm: infra labels and annotations (MAPCO-9060) Helm/ infra labels and annotations (MAPCO-9060) Dec 7, 2025
@roicohen326 roicohen326 changed the title Helm/ infra labels and annotations (MAPCO-9060) chore: add Helm infra labels and annotations (MAPCO-9060) Dec 7, 2025
@roicohen326 roicohen326 merged commit fadd0f5 into master Dec 7, 2025
1 check passed
@roicohen326 roicohen326 deleted the helm/infra-labels-and-annotations branch December 7, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants