Skip to content

feat!: match boilerplate (MAPCO-10816)#18

Open
eyalr1100 wants to merge 37 commits into
masterfrom
feat/match-boilerplate
Open

feat!: match boilerplate (MAPCO-10816)#18
eyalr1100 wants to merge 37 commits into
masterfrom
feat/match-boilerplate

Conversation

@eyalr1100

Copy link
Copy Markdown
Contributor
Question Answer
Bug fix
New feature
Breaking change
Deprecations
Documentation
Tests added
Chore

Related issues: #XXX , #XXX ...
Closes #XXX ...

Further information:

@eyalr1100 eyalr1100 self-assigned this Jun 11, 2026
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

🎫 Related Jira Issue: MAPCO-10816

1 similar comment
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

🎫 Related Jira Issue: MAPCO-10816

@eyalr1100 eyalr1100 marked this pull request as draft June 11, 2026 11:01
@eyalr1100 eyalr1100 marked this pull request as ready for review June 15, 2026 06:10
@eyalr1100 eyalr1100 requested a review from NivGreenstein June 15, 2026 06:10
@NivGreenstein

Copy link
Copy Markdown
Contributor

fix title

Comment thread .github/workflows/build-and-push.yaml Outdated
Comment thread .github/workflows/pull_request.yaml Outdated
Comment thread src/common/config.ts Outdated
Comment thread src/common/interfaces.ts Outdated
Comment thread src/common/interfaces.ts Outdated
Comment thread src/redis/index.ts Outdated
Comment thread src/containerConfig.ts Outdated
Comment thread tests/integration/feedback/feedback.spec.ts Outdated
Comment thread package.json Outdated
Comment thread .release-please-manifest.json
Co-authored-by: Niv Greenstein <88280771+NivGreenstein@users.noreply.github.com>
@eyalr1100 eyalr1100 marked this pull request as draft June 15, 2026 16:59
@eyalr1100 eyalr1100 changed the title Feat!/match boilerplate MAPCO-10816 feat!: match boilerplate MAPCO-10816 Jun 21, 2026
@eyalr1100 eyalr1100 marked this pull request as ready for review June 21, 2026 17:44
@NivGreenstein NivGreenstein changed the title feat!: match boilerplate MAPCO-10816 feat!: match boilerplate (MAPCO-10816) Jun 22, 2026
@eyalr1100 eyalr1100 requested a review from NivGreenstein June 24, 2026 11:08
Comment thread src/common/interfaces.ts Outdated
Comment thread config/default.json Outdated
},
"telemetry": {
"shared": {
"serviceName": "feedback-api"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untitled123123

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set shared as an empty object.
"shared": {}

service name will default from the package.json's name

Comment thread config/default.json Outdated
@eyalr1100 eyalr1100 requested a review from NivGreenstein June 24, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants