feat(grafana): enabled the sidecar dashboard to load dashboards#89
feat(grafana): enabled the sidecar dashboard to load dashboards#89CptSchnitz wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the grafana wrapper chart’s default values to enable Grafana’s dashboards sidecar, allowing dashboards to be automatically discovered and loaded from Kubernetes resources (via configured labels/annotations).
Changes:
- Enable the Grafana sidecar dashboards feature by default.
- Configure the dashboards sidecar label/annotation selectors and provider behavior.
- Add explicit resource requests/limits and a container securityContext for the sidecar.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: monitoring | ||
|
|
||
| sidecar: | ||
| searchNamespace: null |
There was a problem hiding this comment.
Will this operate as expected in the absence of a cluster rule?
There was a problem hiding this comment.
When its null it only monitors the namespace its deployed in.
If you want multiple namespaces you need to supply comma separated values.
For reference, it already works with our existing service account, which does not have cluster rule, im pretty sure.
Co-authored-by: Netanel Cohen <34451523+netanelC@users.noreply.github.com>
No description provided.