Skip to content

feat(openapi-handler): migrate handler to a dedicated package MAPCO-9762#212

Open
netanelC wants to merge 7 commits into
masterfrom
create-handler
Open

feat(openapi-handler): migrate handler to a dedicated package MAPCO-9762#212
netanelC wants to merge 7 commits into
masterfrom
create-handler

Conversation

@netanelC

@netanelC netanelC commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@netanelC netanelC changed the title feat(openapi-helpers): migrate handler to a dedicated package feat(openapi-helpers): migrate handler to a dedicated package MAPCO-9762 Jun 7, 2026
@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown

🎫 Related Jira Issue: MAPCO-9762

@netanelC netanelC requested review from CptSchnitz and ronenkapelian and removed request for ronenkapelian June 9, 2026 05:19
@netanelC netanelC self-assigned this Jun 9, 2026
@netanelC netanelC changed the title feat(openapi-helpers): migrate handler to a dedicated package MAPCO-9762 feat(openapi-handler): migrate handler to a dedicated package MAPCO-9762 Jun 9, 2026
@netanelC netanelC changed the base branch from master to MAPCO-9758-split-openapi-helper-to-3-packages June 9, 2026 05:25

@ronenkapelian ronenkapelian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. .vscode/project.code-workspace — Add folder entry
{
  "name": "openapi-typed-request-handler",
  "path": "../packages/openapi-typed-request-handler",
},
  1. add knip to package.json and validate it
"knip": "knip --directory ../.. --workspace packages/openapi-typed-request-handler"
  1. add typedocs

  2. fix api-extractor:
    a. add etc dir under "packages/openapi-typed-request-handler"
    b.

image then refactor this lines on index.ts c. run pnpm run api and add the output file as part of the commit d. it will solve the ci problem

Comment thread packages/openapi-typed-request-handler/tsconfig.json Outdated
@@ -0,0 +1,29 @@
# openapi-typed-request-handler

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# openapi-typed-request-handler
# @map-colonies/openapi-typed-request-handler

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in other packages it's like I did it

@ronenkapelian ronenkapelian Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the real name of the package.so let fix it here as suggested.

Base automatically changed from MAPCO-9758-split-openapi-helper-to-3-packages to master June 15, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants