helm: refactor ingress.yaml to improve structure and support multiple hosts MAPCO-10675#243
Conversation
Coverage Report
File CoverageNo changed files found. |
michalby24
changed the title
|
🎫 Related Jira Issue: MAPCO-10675 |
ronenkapelian
left a comment
ronenkapelian
left a comment
There was a problem hiding this comment.
-
The template uses six new ingress.* fields that have no defaults in values.yaml. Running helm template or helm lint with a bare values.yaml will silently produce incomplete output for those fields (nil variables), and any chart consumer expecting documented defaults will be surprised.
-
ingress.cors remains in values.yaml but is no longer referenced anywhere in the template — it is dead configuration. should it be templated?
3.Ingress resource name changed ( Breaking) - validate on kela, etc, that the new ingresses and dns working after naming change
| add_header 'Access-Control-Expose-Headers' 'Content-Length'; | ||
| add_header 'Access-Control-Allow-Headers' '*'; | ||
| {{- range $key, $value := . }} | ||
| {{ $key }}: {{ tpl $value $ | quote }} |
There was a problem hiding this comment.
The tpl function requires its first argument to be a string. When an annotation value is an integer or boolean in YAML (e.g. proxy-read-timeout: 60), Helm throws a hard error
Convert the value to a string before passing it to tpl:
2 participants
Related issues: #XXX , #XXX ...
Closes #XXX ...
Further information: