feat: add conditional proxy_pass to backend service in NGINX configuration#43
Closed
almog8k wants to merge 3 commits into
Closed
feat: add conditional proxy_pass to backend service in NGINX configuration#43almog8k wants to merge 3 commits into
almog8k wants to merge 3 commits into
Conversation
almog8k
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a Helm value to conditionally enable/disable proxy_pass to the configured backend service in the rendered NGINX default.conf, allowing the chart to run without proxying to an upstream when desired.
Changes:
- Add
backend.enabledvalue (default set tofalse) to control whetherproxy_passis emitted. - Wrap the NGINX
proxy_passdirective in a Helmifconditional. - Minor YAML quoting normalization for
image.tag.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
helm/values.yaml |
Introduces backend.enabled (and adjusts image.tag quoting) to control backend proxying behavior. |
helm/values.md |
Intended to document the new value in the chart’s generated values table. |
helm/config/default.conf |
Conditionally renders proxy_pass based on backend.enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| backend: | ||
| # -- Enable or disable the proxy_pass to the backend service | ||
| enabled: false |
Comment on lines
19
to
22
| | authorization.enabled | bool | `true` | Use authroization mechanism | | ||
| | authorization.url | string | `"http://localhost:8181/v1/data/http/authz/decision"` | Authorization endpoint | | ||
| | backend.enabled | bool | `false` | Enable or disable the proxy_pass to the backend service | | ||
| | backend.host | string | `"backend-service"` | Backend service name for proxy_pass | |
Contributor
Author
There was a problem hiding this comment.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Updated in commit 285cc32: helm/values.md now includes backend.enabled, backend.host, and backend.port in the generated Values table, so the new flag is documented for chart users.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.