feat: changed opa headers mechanism from whitelist to blacklist#47
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the NGINX njs OPA authorization request payload construction by switching from an explicit header allowlist to a general “pass-through except denylist” mechanism, so OPA receives more request header context by default.
Changes:
- Added a
DENYLISTof request headers to exclude from OPA input. - Introduced
filterHeaders(r)to forward all non-denylistedr.headersInentries to OPA. - Replaced the previous hardcoded header allowlist with
headers: filterHeaders(r)in the OPA input payload.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ronenkapelian
requested changes
Jun 21, 2026
shimoncohen
reviewed
Jun 21, 2026
shimoncohen
approved these changes
Jun 22, 2026
ronenkapelian
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR refactors the NGINX
njsscript to transition our OPA header filtering from an allowlist (whitelist) to a denylist (blocklist).Key benefits of this change:
Cookie, rawAuthorization, legacy tracing, and cache/network noise). This ensures we keep request latency low and OPA payload sizes lean.