fix(agent): resolve graph compilation and cli bugs from review#2
Open
Jaydeep869 wants to merge 1 commit intoMarc-cn:feature/langgraph-agentfrom
Open
fix(agent): resolve graph compilation and cli bugs from review#2Jaydeep869 wants to merge 1 commit intoMarc-cn:feature/langgraph-agentfrom
Jaydeep869 wants to merge 1 commit intoMarc-cn:feature/langgraph-agentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the remaining review feedback, bugs, and CI failures for PR kusari-oss#137 on the main repository. Merging this into your
feature/langgraph-agentbranch will automatically update PR kusari-oss#137 and resolve the failing checks.Fixes included:
UnboundLocalErrorincmd_run()by ensuringfinal_stateis handled and adding an early return if the agent graph layout fails.cmd_profilesfunction that was lost during a recent merge withmain, which was causinguv run darnit --helpand several tests to crash with aNameError.langgraphimports (StateGraph,END) entirely insidebuild_graph()to fix theModuleNotFoundErrorduringpytestcollection.len(tools) >= 15to account for new commands merged frommain.ruffCI check passes.Type of Change
Framework Changes Checklist
If this PR modifies the darnit framework (
packages/darnit/):openspec/specs/framework-design/spec.md) if behavior changeduv run python scripts/validate_sync.py --verboseand it passesuv run python scripts/generate_docs.pyand committed any doc changesControl/TOML Changes Checklist
If this PR modifies controls or TOML configuration:
Testing
uv run pytest tests/ -v)uv run ruff check .)Additional Notes
Tested locally and the full suite passes!