fix: update dot-project spec hash and mcp expected tools count#3
Open
Jaydeep869 wants to merge 1 commit intoMarc-cn:feature/reproducibility-pluginfrom
Open
Conversation
Author
|
resolve kusari-oss#138 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI test failures occurring in the PR. Updated the
test_mcp_server.pyintegration test to expect 18 MCP tools instead of 15, accounting for the new tools added recently. Additionally, updated the.project/spec hash to resolve a synchronization failure intest_dot_project_upstream.pycaused by an upstream CNCF spec change.Type of Change
Framework Changes Checklist
If this PR modifies the darnit framework (
packages/darnit/):openspec/specs/framework-design/spec.md) if behavior changeduv run python scripts/validate_sync.py --verboseand it passesuv run python scripts/generate_docs.pyand committed any doc changesControl/TOML Changes Checklist
If this PR modifies controls or TOML configuration:
Testing
uv run pytest tests/ -v)uv run ruff check .)Additional Notes
The CI was failing on two specific tests:
tests/integration/test_mcp_server.py- Fixed by updating the expected tools list and count (from 15 to 18).tests/darnit/context/test_dot_project_upstream.py- Fixed by running--update-hashto sync the new upstream.projectspec hash.