bit rot patches + working fcl 0.7 support + minor cleanup of LGP test#8
Open
v4hn wants to merge 8 commits intoMarcToussaint:masterfrom
Open
bit rot patches + working fcl 0.7 support + minor cleanup of LGP test#8v4hn wants to merge 8 commits intoMarcToussaint:masterfrom
v4hn wants to merge 8 commits intoMarcToussaint:masterfrom
Conversation
Found trying to compile on debian testing.
null_deleter (boost-specific) was never directly included and fails on Debian testing (due to include changes down the include chain?) I replaced it by an equivalent lambda.
useSwitches does not exist anymore since 8c83372 . Hrate and FlagConstraints only exist in retired code or comments. TM_Physics not at all. collisions is a boolean, and enabled by default. Keeping it commented out looks like it might be disabled by default.. "problem" exists in some tools and python bindings, but not in the C++ codebase.
It took me a while to change the task to move all four objects over, mostly because the runtime was implicitly restricted here. The config is already constraint by solutions and overall runtime, so this third threshold does not seem helpful.
'#(' looks like some more confusing special syntax, when it's really
just commented statements.
I gave it a slightly tinted color so that it does not disrupt the visualization, but is visible for someone who cares.
MarcToussaint
force-pushed
the
master
branch
from
523dc59 to
0d28d41
Compare
MarcToussaint
force-pushed
the
master
branch
2 times, most recently
from
c6a45e1 to
f5ab514
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for pointing me to the correct place from MarcToussaint/robotic#8, @MarcToussaint .
It turns out
masterandmarcare both broken in the same ways in my Debian testing, so I wrote a few patches and create this pull request againstmasterto get it to run ootb again.As I worked my way through the code, I added a few more patches on top to help someone like me understand it a bit better and make it easier to vary the scenario a bit.
Although you buried it a bit, it's still a nice demo 👍 .