MDBF-1202: Prefer pull_request over push for same-commit tarball builds#956
Merged
RazvanLiviuVarzaru merged 1 commit intoApr 21, 2026
Merged
Conversation
RazvanLiviuVarzaru
force-pushed
the
duplicate-builds
branch
from
0d1da39 to
a634c28
Compare
RazvanLiviuVarzaru
changed the title
Collaborator
Author
|
Example: Both tarballs started: From the Pull Request perspective: And https://buildbot.dev.mariadb.org/#/builders/110/builds/294 |
Collaborator
|
LG but I prefer leaving the review to Daniel (unless you want to test this today, then ping me). |
Collaborator
Author
Already tested it on dev. See my first comment. |
grooverdan
approved these changes
Apr 21, 2026
Member
grooverdan
left a comment
grooverdan
left a comment
There was a problem hiding this comment.
Looks good to me. Might just need to extend to include preview brances.
Buildbot treats push and pull_request events independently. The scheduler can trigger tarball-docker for both event types, while push events are only considered when the upstream branch matches a configured pattern such as bb-* or st-*. When a pull request is opened from a branch in the upstream repository, the source branch may also match the push-event filter. In that case, two tarball builds can be scheduled for the same commit: one from the push event and one from the pull_request event. This patch cancels the tarball triggered by the push event and keeps only the pull_request build, since that is the one relevant for branch protection and GitHub Checks. Note that *-pkgtest builds cannot be run meaningfully from both a pull request and the corresponding upstream branch at the same time. Any pkgtest should therefore be completed before opening the pull request.
RazvanLiviuVarzaru
force-pushed
the
duplicate-builds
branch
from
a634c28 to
72ce350
Compare
Member
|
🛩️ 👍 Good to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buildbot treats push and pull_request events independently. The scheduler can trigger tarball-docker for both event types, while push events are only considered when the upstream branch matches a configured pattern such as bb-* or st-*.
When a pull request is opened from a branch in the upstream repository, the source branch may also match the push-event filter. In that case, two tarball builds can be scheduled for the same commit: one from the push event and one from the pull_request event.
This patch cancels the tarball triggered by the push event and keeps only the pull_request build, since that is the one relevant for branch protection and GitHub Checks.
Note that *-pkgtest builds cannot be run meaningfully from both a pull request and the corresponding upstream branch at the same time. Any pkgtest should therefore be completed before opening the pull request.