Skip to content

Hw5 lukina#1

Open
MariaLuk wants to merge 4 commits intomainfrom
HW5_lukina
Open

Hw5 lukina#1
MariaLuk wants to merge 4 commits intomainfrom
HW5_lukina

Conversation

@MariaLuk
Copy link
Copy Markdown
Owner

@MariaLuk MariaLuk commented Oct 8, 2023

No description provided.

Copy link
Copy Markdown

@SidorinAnton SidorinAnton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Красиво! ))

Comment thread README.md
Comment on lines +33 to +39
```Python
amino_acid_tools('DNA', 'russco', 'LOLkEk', 'azaz', 'three_letter_code')
```
Output: ['AspAsnAla', 'ArgSecSerSerCysPyl', 'LeuPylLeuLysGluLys', 'unexpected symbols in sequence']

```Python
amino_acid_tools('DNA', 'russco', 'LOLkEk', 'azaz', 'letter_code')
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

)))0)0
Хотя всё-таки в "официальной документации" так делать не надо ))

Comment thread modules/fastq_filters.py
"""
n = 0
for nucl in seq:
if nucl == 'c' or nucl == 'g' or nucl == 'C' or nucl == 'G':
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А можно просто .upper()

Returns:
(str): oligo- and polynucleotide sequence
"""
return complement(seq)[::-1]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return reverse(complement(seq))

Comment on lines +1 to +3
import modules.nucleic_acids_functions as na
import modules.fastq_filters as ff
import modules.amino_acids_functions as aa
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно не переназывать ))

import modules.nucleic_acids_functions as na
import modules.fastq_filters as ff
import modules.amino_acids_functions as aa
NUCLEOTIDES = {'U', 'A', 'g', 't', 'G', 'T', 'a', 'c', 'C', 'u'}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не хватает отступа после импорта

Comment on lines +135 to +136
good_seqs = ff.filter_length(ff.filter_quality(ff.filter_gc(seqs, gc_bounds_both_side), quality_treshold),
length_bounds_both_side)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Классно, но, имхо, через переменные красивее ))

filtered_by_gc = filter_gc(seqs, ...)
filtered_by_quality = filter_quality(filtered_by_gc, ...)
filtered_by_len = filter_length(filtered_by_quality, ...)

Прост фильтров же может быть еще 10 ))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants