Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Quick Look preview zoom handling to avoid hard-coded zoom constants by centralizing the default zoom in a CSS custom property and reusing it in related layout calculations.
Changes:
- Introduces
--quicklook-default-zoomand uses it forzoomand toolbar-clearancemargin-topmath instyles/quicklook.css. - Updates the compact-layout zoom override to set the default zoom variable instead of re-declaring
zoom. - Updates pinch-zoom tracking to write
--quicklook-zoomfrom the element’s zoom value (and updates the committed dist bundle accordingly).
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| styles/quicklook.css | Centralizes default zoom into --quicklook-default-zoom and removes duplicated hard-coded constants. |
| src/quicklook/interaction.ts | Updates how --quicklook-zoom is written during gesture events (needs a guard to preserve CSS fallback behavior). |
| dist/markedit-preview.js | Regenerated bundle reflecting the zoom default refactor and gesture handling change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.