Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Quick Look segmented control so that, in compact mode, the “Source” and “Preview” tabs display icons instead of text labels while keeping full labels available for accessibility and non-compact layouts.
Changes:
- Add icon and label wrapper elements to Quick Look toolbar buttons (with
title/aria-labelfor accessibility). - Add CSS to hide labels and show SVG icons in compact mode, while hiding icons in the regular layout.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| styles/quicklook.css | Adds compact-mode rules to swap segment labels for icons and sizes the SVGs appropriately. |
| src/quicklook/toolbar.ts | Updates toolbar button creation to include both a text label span and an inline SVG icon span. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.