Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Markdown fenced code block insertion behavior in the CoreEditor, especially when typing backticks, by switching to snippet-based insertion with placeholders and by allowing snippets to target an explicit replacement range.
Changes:
- Extend
insertSnippet()to optionally replace an explicit{ from, to }range rather than always using the main selection. - Rework backtick input handling to convert
``into a fenced code block with placeholders and ensure fences are placed on their own lines, avoiding insertion while already inside code. - Update the “Insert Code Block” command to use snippet placeholders for language/content when selection is a single, single-line range.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| CoreEditor/src/modules/snippets/insertSnippet.ts | Adds an optional replacement range to support non-selection snippet insertions. |
| CoreEditor/src/modules/input/insertCodeBlock.ts | Replaces prior dispatch-based insertion with snippet-based fenced block insertion + syntax-tree checks. |
| CoreEditor/src/modules/commands/index.ts | Updates the code block command to use snippet placeholders when safe (single selection, single line). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.