Skip to content

Improve 3-backtick to insert code blocks#1493

Merged
cyanzhong merged 1 commit into
mainfrom
develop
Jun 17, 2026
Merged

Improve 3-backtick to insert code blocks#1493
cyanzhong merged 1 commit into
mainfrom
develop

Conversation

@cyanzhong

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves Markdown fenced code block insertion behavior in the CoreEditor, especially when typing backticks, by switching to snippet-based insertion with placeholders and by allowing snippets to target an explicit replacement range.

Changes:

  • Extend insertSnippet() to optionally replace an explicit { from, to } range rather than always using the main selection.
  • Rework backtick input handling to convert `` into a fenced code block with placeholders and ensure fences are placed on their own lines, avoiding insertion while already inside code.
  • Update the “Insert Code Block” command to use snippet placeholders for language/content when selection is a single, single-line range.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
CoreEditor/src/modules/snippets/insertSnippet.ts Adds an optional replacement range to support non-selection snippet insertions.
CoreEditor/src/modules/input/insertCodeBlock.ts Replaces prior dispatch-based insertion with snippet-based fenced block insertion + syntax-tree checks.
CoreEditor/src/modules/commands/index.ts Updates the code block command to use snippet placeholders when safe (single selection, single line).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CoreEditor/src/modules/input/insertCodeBlock.ts
Comment thread CoreEditor/src/modules/input/insertCodeBlock.ts
Comment thread CoreEditor/src/modules/commands/index.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Comment thread CoreEditor/src/modules/input/insertCodeBlock.ts
Comment thread CoreEditor/src/modules/commands/index.ts
Comment thread CoreEditor/src/modules/input/insertCodeBlock.ts
Comment thread CoreEditor/src/modules/commands/index.ts
@cyanzhong cyanzhong merged commit ced9332 into main Jun 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants