Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Quick Look (PreviewExtension) theme syncing by driving the lightweight editor’s theme from the system/forced color scheme, and by updating the WKWebView/AppKit appearance together so the web content reacts to appearance changes more reliably.
Changes:
- Replace the preview extension’s manual JS theme switching with a
prefers-color-scheme-driven theme insideCoreEditor/src/@light. - Add a shared app-group
UserDefaults.forcedColorSchemeoverride so the host app can communicate light/dark forcing to the preview extension. - Consolidate preview appearance updates into
updateAppearance()(background +webView.appearance) and simplify previewEditorConfigcreation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| PreviewExtension/PreviewViewController+UI.swift | Adds updateAppearance() and uses app-group forced color scheme to compute dark mode. |
| PreviewExtension/PreviewViewController.swift | Switches from background/theme updates to a single updateAppearance() call; removes passing theme into preview config. |
| PreviewExtension/PreviewViewConfig.swift | Removes theme parameter from previewConfig; hardcodes a placeholder theme string for @light. |
| MarkEditMac/Sources/Main/AppDocumentController.swift | Writes forcedColorScheme during open panel lifetime to keep preview extension in sync with app appearance setting. |
| MarkEditCore/Sources/Extensions/UserDefaults+Extension.swift | Introduces shared app-group forcedColorScheme storage API. |
| CoreEditor/src/@light/index.ts | Derives theme from matchMedia('(prefers-color-scheme: dark)') and updates on changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.