Fix Keychain profile metadata storage#26
Merged
Conversation
added 6 commits
March 17, 2026 12:15
toby-winter-bot
force-pushed
the
fix/keychain-profile-json
branch
from
755d919 to
627d44b
Compare
martin-alexander-msc
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Keychain storage so the full GitwProfile JSON is stored and retrievable reliably.\n\n- Store profile as generic-password item (service: gitw.github.com)\n- kSecValueData contains JSON-encoded GitwProfile\n\nThis fixes: 'profile for alias ... is missing profile metadata (expected JSON)'.\n\nTests: swift test